refactor: remove remaining injectIntl(), ban it using eslint#2585
refactor: remove remaining injectIntl(), ban it using eslint#2585ChrisChV merged 2 commits intoopenedx:masterfrom
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2585 +/- ##
==========================================
+ Coverage 94.78% 94.81% +0.03%
==========================================
Files 1225 1225
Lines 27399 27481 +82
Branches 5992 6188 +196
==========================================
+ Hits 25969 26056 +87
+ Misses 1372 1354 -18
- Partials 58 71 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisChV
left a comment
ChrisChV
left a comment
There was a problem hiding this comment.
@bradenmacdonald Looks good! Thanks for this work!
👍
- I tested this: I verified the settings components
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
- Includes documentation/comments
|
Thanks @ChrisChV ! |
3 participants
Description
This finished the removal of
injectIntlfrom this codebase, and configures a new eslint rule to ban it completely.Testing instructions
Verify modified settings components are working.
Other information
Private ref MNG-4670
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'